Adjust ESP detection to catch zfsbootmenu

[superm1]

Type of pull request:

• New plugin (Please include new plugin checklist)
• Code fix
• Feature
• Documentation

[hughsie]

I'd feel a lot more soft and squishy if this had self tests tbh.

[superm1]

I'd feel a lot more soft and squishy if this had self tests tbh.

The problem is we need a template for udisks2 in dbusmock. Without that we can't come up with good setups for the crazy disk setups.

martinpitt/python-dbusmock#203

[hughsie]

I wondered if we could mock something up just by shoving the FuVolumes into fu_context_get_esp_volumes manually -- e.g. in the uefi-capsule fu-self-test.c

[superm1]

fu_context_get_esp_volumes

But then we try to go and mount them. Since we made udisks2 mandatory, I don't think this will work.

[hughsie]

But then we try to go and mount them.

Hmm, true.

[superm1]

To add more. We have FWUPD_UEFI_ESP_PATH but this is specifically for the test suite to specify a single ESP path, not a series of paths. We can certainly look for a few fake files under this path but I don't think we can come up with a path that reflects heuristics selection between two groups of paths with various files and which one gets ranked like this.

[hughsie]

Thanks