Hughsie/fwupd codec improvements #7338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will also mean we don't paint outself into a corner for the future.
It's way less confusing this way.
This means we can export to JSON from libfwupdplugin objects too.
hughsie
force-pushed
the
hughsie/FwupdCodec-improvements
branch
from
0a45770
to
eed7700
Compare
superm1
previously approved these changes
Jun 11, 2024
For trivial objects we only need one 'format instance variables' function. NOTE: we're deliberately not using FwupdCodec->add_variant() as this is typically encoding the low-level "raw" values used to re-create the object the other side of the DBus socket, rather than the user-friendly strings we want in the JSON and string debug output.
hughsie
force-pushed
the
hughsie/FwupdCodec-improvements
branch
from
6793cd9
to
5a813f1
Compare
superm1
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request: