Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't obvious that I need to have a node to run the selenium tests. This PR adds a
package.json
file so we can have a proper place for dev dependencies as well as defining the version of node that is supported (via theengines
key).Now locally we can simply setup via:
And then run the tests by having the Rust server running on port 3000 and:
$ npm test
馃摕 @michielbdejong @JohanLorenzo
If this is ok with you I'd like to add some instructions about this to the readme before merging.