Merge pull request #38 from fxos/bug1164644

Bug 1164644 - [Customizer] Update Attributes/Properties inspectors to…
fxos · May 29, 2015 · be5a0ac · be5a0ac
2 parents 4ca4c69 + 772fe3d
commit be5a0ac
Show file tree

Hide file tree

Showing 6 changed files with 584 additions and 53 deletions.
diff --git a/app/js/controllers/edit.js b/app/js/controllers/edit.js
@@ -30,6 +30,14 @@ export default class EditController extends Controller {
         generator.opScript(this.changes.script);
       }
 
+      if (this.changes.createAttributes) {
+        generator.opCreateAttributes(this.changes.createAttributes);
+      }
+
+      if (this.changes.removeAttributes) {
+        generator.opRemoveAttributes(this.changes.removeAttributes);
+      }
+
       if (this.changes.properties) {
         generator.opSetProperties(this.changes.properties);
       }

diff --git a/app/js/elements/fxos-code-editor.js b/app/js/elements/fxos-code-editor.js
@@ -48,7 +48,9 @@ var template =
   }
 </style>
 <div class="container">
-  <div class="line-numbers"></div>
+  <div class="line-numbers">
+    <div>1</div>
+  </div>
   <textarea wrap="off"></textarea>
 </div>`;
 
@@ -80,7 +82,6 @@ Object.defineProperty(proto, 'value', {
 
   set: function(value) {
     this.textarea.value = value;
-    this.dispatchEvent(new CustomEvent('change'));
     updateLineNumbers(this);
   }
 });