Switch to cobra/viper for CLI, allow env var override #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* You can now override configuration using environment variables: "LOGINAPP_ABC" where ABC is the full path of the variable to override, exemple: LOGINAPP_OIDC_CLIENT_ID=mycustomid will override oidc.client.id key from config closes #20 * In order to allow env var overrides, we had to change some variable name. All variables (excluded `clusters` vars) follow a lower camel case convention: - `redirect_url` --> `redirectURL` - `root_ca` --> `rootCA` - `extra_scopes` --> `extraScopes` - `extra_auth_code_opts` --> `extraAuthCodeOpts` - `offline_as_scope` --> `offlineAsScope` - `cross_clients` --> `crossClients` - `main_username_claim` --> `mainUsernameClaim` - `main_client_id` --> `mainClientID` - `assets_dir` --> `assetsDir` - `templates_dir` --> `templatesDir` * minor code refactoring * Issue in templating, `Name` was not overrided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now override configuration using environment variables:
"LOGINAPP_ABC" where ABC is the full path of the variable to override,
exemple: LOGINAPP_OIDC_CLIENT_ID=mycustomid will override
oidc.client.id key from config
closes Support oidc client secret from environment variable or file #20
In order to allow env var overrides, we had to change some variable
name. All variables (excluded
clustersvars) follow a lower camel caseconvention:
redirect_url-->redirectURLroot_ca-->rootCAextra_scopes-->extraScopesextra_auth_code_opts-->extraAuthCodeOptsoffline_as_scope-->offlineAsScopecross_clients-->crossClientsmain_username_claim-->mainUsernameClaimmain_client_id-->mainClientIDassets_dir-->assetsDirtemplates_dir-->templatesDirminor code refactoring
Issue in templating,
Namewas not overrided