Try to not rebuild the base image and download it instead. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andydotxyz
reviewed
Nov 20, 2023
.github/workflows/cd.yml
Outdated
| @@ -31,4 +31,6 @@ jobs: | |||
| - name: Build all images | |||
| run: | | |||
| make -f Makefile.multi docker-all | |||
| docker pull docker.io/fyneio/fyne-cross-images:v1.1.4-base | |||
There was a problem hiding this comment.
Should 1.1.4 be used for all updates, or will we want to change this frequently? Perhaps a variable if we can't automatically figure out the latest version?
There was a problem hiding this comment.
Oh, good catch, it should be latest instead. Will fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the android image, we currently don't have it locally as buildx multiplatform automatically push it and does not make it available locally. This is trying to download locally the amd64 v1.1.4-base image that was just build for multi target and reuse it for building the android image.