Merge/develop #188
Merged
Merge/develop #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andy Williams <andy@andy.xyz>
Co-authored-by: Jacob Alzén <jacob.alzen@gmail.com>
Releases/v1.4.0 rc1
This can only be used with vendored directory. It does provide two main benefit. First not setting up network, means that the build will not be able to get any data from the outside. It give you that guarantee that only the source code that is in your vendor directory was used. Second it is faster to setup a container without network.
Add ability to disable network in the container while building.
andydotxyz
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the change that went into v1.4.0 release were on a branch that didn't land in develop apparently. This PR is merging master into develop to be back in sync.