Releases/v1.4.0 rc1

[Bluebugs]

Description:

This push all the change waiting in develop into master for the v1.4.0 release.

Checklist:

• Tests included.
• Lint and formatter run with no errors.
• Tests all pass.

Where applicable:

• Public APIs match existing style.

[andydotxyz]

I have tested the result of the freebsd/arm64 - but not the build process so cannot say if Jacob is on to something or not, will try later.

[andydotxyz]

I can replicate the error that @Jacalz reported now - it seems to be triggered by using Fyne v2.3.2.
I cannot currently figure out why that version is tying to compile the mobile driver - and did we somehow miss that in release testing, or is it triggered by using the zig compiler?

[andydotxyz]

It looks like Fyne-cross is telling the compiler to include gles for some reason...

/usr/local/bin/docker run --rm -t -w /app -v /Users/andy/Code/Fyne/examples:/app -v /Users/andy/Library/Caches/fyne-cross:/go --platform linux/arm64 -u 501:20 --entrypoint fixuid -v /private/tmp/com.apple.launchd.XZOtnKWCzD/Listeners:/tmp/ssh-agent -e SSH_AUTH_SOCK=/tmp/ssh-agent -e CGO_ENABLED=1 -e GOCACHE=/go/go-build -e GOARCH=arm64 -e CC=zig cc -target aarch64-linux-gnu -isystem /usr/include -L/usr/lib/aarch64-linux-gnu -e CXX=zig c++ -target aarch64-linux-gnu -isystem /usr/include -L/usr/lib/aarch64-linux-gnu -e GOOS=linux docker.io/fyneio/fyne-cross-images:linux /usr/local/bin/fyne package -os linux -name examples -icon /app/fyne-cross/tmp/linux-arm64/Icon.png -appBuild 1 -appVersion 1.0.0 -tags "gles" -release

[Bluebugs]

@andydotxyz the strange bit is that you are building for arm64 while @Jacalz is building for amd64. On arm64, it is expected to have the gles tag. So that part is normal, but it isn't normal that we borked it.

[andydotxyz]

I don't think it is expected to set the tag manually... the compile should handle it automatically rather than set on the tag list.
Unless I have misunderstood how fyne-cross is using the fyne build

[Bluebugs]

I am not to sure what you mean. Should we expect fyne to automatically add the gles tag and that code is not needed anymore in fyne-cross?

[andydotxyz]

The tag should not be required, and "fyne build" does not need to add it either.
We use GOOS/GOARCH to determine what GL to use don't we?

[Bluebugs]

In that case that tag might be historical and could be removed, I guess.

[andydotxyz]

The issue itself may not be with the tag. It seems a change in a recent release brings in mobile as a dep to anything not darwin.

The following change to the release/v2.3.x branch fixes it in my testing:

diff --git a/internal/painter/gl/gl_const_other.go b/internal/painter/gl/gl_const_other.go
index 239bee457..da17f83ba 100644
--- a/internal/painter/gl/gl_const_other.go
+++ b/internal/painter/gl/gl_const_other.go
@@ -1,5 +1,6 @@
-//go:build !darwin && !js && !wasm
+//go:build !darwin && !js && !wasm && (android || ios)
 // +build !darwin,!js,!wasm
+// +build android,ios

[Jacalz]

I can confirm that everything is back to working with Fyne v2.3.3. FreeBSD compiles work fine on armd64 👍

[Jacalz]

Looks good to me 👍

[andydotxyz]

Looks like a good rc1 - is the plan to cut rc2 after #180 and #182, or update here?

[Bluebugs]

Looks like a good rc1 - is the plan to cut rc2 after #180 and #182, or update here?

I went with update here. This way it is one merge in main.

[lucor]

Great job! Thanks @Bluebugs