Add baseline to font measurement #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update RichText to realign lines where the baseline varies across the row
fpabl0
reviewed
Jul 13, 2021
fpabl0
reviewed
Jul 14, 2021
fpabl0
reviewed
Jul 24, 2021
fpabl0
reviewed
Jul 27, 2021
fpabl0
reviewed
Jul 27, 2021
|
Sorry I keep coming to this and fixing a naming then we find some more. |
|
Sorry, it is quite difficult to navigate through 537 files. I thought that when FontMetrics rename was accepted, fontSizeCache would be renamed as it seems to be the more logical change. Same in |
|
Not a problem, the font painter names fixed but the cache keys are size/style not metric so I think that one is OK. |
fpabl0
approved these changes
Jul 27, 2021
Not at all, thanks for your help getting this over the line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add font information to (driver) text measurement.
The
MeasureTextcall remains consistent so no public API breakage (except driver, as discussed elsewhere).There could be a new version of that to expose baseline info, but I don't yet see the need.
What this also did was fix precision of text calculations so a lot of tests/images have changed slightly.
Fixes #1859
Checklist: