Add Bold and Underline to TextGrid widget

[mgazza]

Description:

Enable the text style to be passed in as part of the TextGridStyle. this will allow font options to be passed down

Checklist:

• Tests included.
• Lint and formatter run with no errors.
• Tests all pass.

Where applicable:

• Public APIs match existing style and have Since: line.
• Any breaking changes have a deprecation path or have been discussed.
• Check for binary size increases when importing new modules.

[coveralls]

coverage: 65.566% (-0.004%) from 65.57%
when pulling 123747e on codelaboratoryltd:feature/text-grid-highlighting
into 389162b on fyne-io:develop.

[andydotxyz]

Looks good. A few comments inline about since notes and naming.

Would it be possible to add a test?

Also I think you might find that although the APIs are added they do not take effect on output...
You'll need to extend the code in internal/painter/font.go I think (line 35 onwards). It will likely be necessary to pass the style in to the actual theme Font call instead of using the helper methods which are limited to monospace vs all other styles...

[mgazza]

quick demo

[andydotxyz]

You'll need to extend the code in internal/painter/font.go I think (line 35 onwards). It will likely be necessary to pass the style in to the actual theme Font call instead of using the helper methods which are limited to monospace vs all other styles...

I'm curious about how you got the demo working with that font cache not patched - did you find that it wasn't a problem for some reason? How was the bold monospace font looked up in that demo?

[mgazza]

You'll need to extend the code in internal/painter/font.go I think (line 35 onwards). It will likely be necessary to pass the style in to the actual theme Font call instead of using the helper methods which are limited to monospace vs all other styles...

I'm curious about how you got the demo working with that font cache not patched - did you find that it wasn't a problem for some reason? How was the bold monospace font looked up in that demo?

overriding the theme was all that was needed

[andydotxyz]

Yup I appreciate that the API was designed to make this possible - but I'm pretty sure you'll get cache collisions inside the toolkit as it does not understand bold monospace.

Happy to be proved wrong on this of course, but it's a concern.

[mgazza]

Yup I appreciate that the API was designed to make this possible - but I'm pretty sure you'll get cache collisions inside the toolkit as it does not understand bold monospace.

Happy to be proved wrong on this of course, but it's a concern.

I haven't seen any, it sounds like an ideal unit test candidate, however. Is there a table test which I can add a test case to?

[andydotxyz]

I haven't seen any, it sounds like an ideal unit test candidate, however. Is there a table test which I can add a test case to?

The problem will be in CachedFontFace of internal/painter/font.go and there is a font_internal_test.go used to test caching and other non-public API.

[mgazza]

When running the tests locally, I get quite a few failures. I have checked to ensure no more/other tests are failing due to this work. I can't see how CachedFontFace is affected, it appears to call the theme font in every case from what I can see. I may be missing something however.

[andydotxyz]

When running the tests locally, I get quite a few failures. I have checked to ensure no more/other tests are failing due to this work. I can't see how CachedFontFace is affected, it appears to call the theme font in every case from what I can see. I may be missing something however.

I can't figure out how! The OpenGL driver text rendering uses the cached face to draw. it is created in internall/painter/gl/texture.go:155, and the text style passed in uses only the Monospace field in the case of mono, ignoring the others. I cannot find any other routes to get to DrawString which is the entry point for rendering text...

[andydotxyz]

I just realised that TextGridTextStyle does not handle Italics... so would that be another new interface in the future? It's looking more and more like a duplication of the TextStyle struct!

[andydotxyz]

When running the tests locally, I get quite a few failures.

There should not be - there is an intermittent issue due to window sizing and OS not always allowing it during the test IIRC. If the CI does not see failures then it's probably OK but worth opening a bug to report that it's not all working at your end.

[andydotxyz]

When running the tests locally, I get quite a few failures.

Latest develop should have all the test failures resolved.
Shall we try and get something based on this in to 2.5? Would be good to have the TextStyle used on more widgets.

[mgazza]

Sorry for the delay, yeah it would be good to have this into 2.5

[andydotxyz]

That might be tough, yesterday was feature freeze. I remain concerned that adding "TextGridTextStyle" in addition to "TextGridStyle" and "TextStyle" is confusing and the discussion about bold/bolded underline/underlined would be avoided by using the existing APIs

[mgazza]

I hope the last commit aligns more with your thinking?

[andydotxyz]

I hope the last commit aligns more with your thinking?

This seems much more consistent thanks.
There is a conflict stopping CI from running unfortunately. Either way I added some small thoughts inline.

[mgazza]

I hope the last commit aligns more with your thinking?

This seems much more consistent thanks. There is a conflict stopping CI from running unfortunately. Either way I added some small thoughts inline.

Thanks, I'll add the comments and tidy up the branch so its much more atomic :D

[andydotxyz]

Thanks so much, this is great to have in.

[andydotxyz]

I guess the apps would need a bold monospace font in the theme to see the difference on that right? Perhaps we should consider with the new system font lookup to find local defaults that are more flexible? A later PR works for that.

Also, I am curious - is italic being included for the TextGrid lots of extra work or would it follow the same model?

Thanks again for sticking through the process here.

[mgazza]

The same model will work for italics. yes you have to return a different font for bold and italics in the font lookup