Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework activity widget to not talk directly with renderer #4861

Merged
merged 3 commits into from
May 22, 2024
Merged

Rework activity widget to not talk directly with renderer #4861

merged 3 commits into from
May 22, 2024

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented May 21, 2024

Description:

Similar to recent changes to progress bar infinite, this applies the same change to Activity.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 65.043% (+0.004%) from 65.039%
when pulling b685b73 on Jacalz:activity-no-internal
into a287ba6 on fyne-io:develop.

andydotxyz
andydotxyz approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@Jacalz Jacalz merged commit 9810934 into fyne-io:develop May 22, 2024
12 checks passed
@Jacalz Jacalz deleted the activity-no-internal branch May 22, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jacalz @coveralls @andydotxyz