Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use test themes in tests #4948

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

toaster
Copy link
Member

@toaster toaster commented Jun 18, 2024

Description:

This PR changes the tests to use the test themes instead of the production themes.
Test themes are guaranteed to have unique color values and thus avoid false positive tests.
Also, this allows theme adjustments with less to none affect on image based tests.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@toaster toaster requested a review from andydotxyz June 18, 2024 09:24
@toaster toaster changed the title Refactoring/test themes use test themes in tests Jun 18, 2024
@toaster toaster changed the base branch from master to develop June 18, 2024 09:25
@Jacalz
Copy link
Member

Jacalz commented Jun 18, 2024

Nice. This is something that I've wanted for a long time :)

@toaster
Copy link
Member Author

toaster commented Jun 18, 2024

Nice. This is something that I've wanted for a long time :)

Feel free to approve, then :).

@coveralls
Copy link

Coverage Status

coverage: 65.858% (+0.01%) from 65.847%
when pulling 20982c9 on toaster:refactoring/test_themes
into beb7392 on fyne-io:develop.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I guess we could remove the intTheme helpers once this is completed too perhaps?

@toaster toaster merged commit a17e7b9 into fyne-io:develop Jun 18, 2024
12 checks passed
@toaster
Copy link
Member Author

toaster commented Jun 18, 2024

Cool, I guess we could remove the intTheme helpers once this is completed too perhaps?

Probably

@toaster toaster deleted the refactoring/test_themes branch June 20, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants