Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

UK Postcodes - Some of the values are no longer valid #1443

Closed
zhibek opened this issue Mar 6, 2018 · 1 comment
Closed

UK Postcodes - Some of the values are no longer valid #1443

zhibek opened this issue Mar 6, 2018 · 1 comment

Comments

@zhibek
Copy link

zhibek commented Mar 6, 2018

Royal Mail is the authoritative source for postcodes in the UK. The website provides a page making it possible to lookup/check postcodes:
https://www.royalmail.com/find-a-postcode

This webpage shows several postcodes included in Faker are no longer valid:

KT18 5DN
AB15 4YR
B62 8RS

PR #1440 has removed these postcodes. What needs to be done to verify / merge this PR? Currently several of our tests are failing occasionally due to our reliance on Faker and these invalid postcodes that are sometimes provided.
DivineOmega pushed a commit to rapidwebltd/php-postcodes that referenced this issue Apr 16, 2018
Add checks against invalid postcodes mentioned in fzaninotto/Faker#1443
fae337d
@zhibek
Copy link
Author

zhibek commented Sep 14, 2018

Closing issue after commit referenced above.

@zhibek zhibek closed this as completed Sep 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zhibek