This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Remove an invalid Dutch lastname that breaks email generator #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble). This lastname does not exist anywhere, and breaks the email name generator. The email name generator does not strip the last dot, which results in: `Hassan.Jolijn@Jasperdr..net`. This is an invalid email address according to PHP.
fzaninotto
added a commit
that referenced
this pull request
Oct 12, 2015
Remove an invalid Dutch lastname that breaks email generator
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the lastname
Jasper dr.toJasper dr. This lastname (with dot) does not occur anywhere in the Netherlands, plus it breaks the email generator. The email generator does not strip the last dot, so it can generate an email like this:Hassan.Jolijn@Jasperdr..net.This is, of course, an invalid email address according to PHP.