ka_GE: overall improvements to ka_GE locale

[hertzg]

General improvemens were made to existing Provides as well
as added Company and Lorem providers (generators)

ka_GE\Address:

• trimed items in arrays
• added multiple address formats (full, short and etc.)
• added cityFormats
• added regionGenitiveForm (gramar)

ka_GE\Company:

• generates names using popular name elements with affixes

ka_GE\Internet:

• added items to freeEmailDomain array
• added all supported Georgian TLDs

ka_GE\Lorem:

• added about 300 localized lorem words

ka_GE\Person:

• added titles for genders

[hertzg]

/cc @fzaninotto All Green.

[fzaninotto]

Lorem is never localized, please remove this class.

[fzaninotto]

please remove this phpDoc

[hertzg]

@fzaninotto Is there any specific reason why Lorem is never localized? Because when using $faker->word, $faker->sentence, $faker->paragraph and/or friends on a localized Generator, It makes sense for the result to be localized. It's also very useful when testing specific localized fonts (in PDFs for example or some other generated content as well as on websites).

[okj579]

There's a provider for that. It's called Text.

On Tue, May 17, 2016, 22:23 Giorgi Kotchlamazashvili <
notifications@github.com> wrote:

@fzaninotto https://github.com/fzaninotto Is there any specific reason
why Lorem is never localized? Because when I'm using $faker->word,
$faker->sentence, $faker->paragraph and friends on a localized Generator
it makes sense for the result to be localized. It's also very useful when
testing specific localized fonts (in PDF's for example or some other
generated content as well as website).

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#913 (comment)

[hertzg]

@okj579 The Text provider provides data only for $faker->realText() which generates text up to $maxNbChars as opposed to $faker->word, $faker->sentence, $faker->paragraph and similar functions do.

To rephrase: When I want to generate a random localized word, sentence or paragraph the most intuitive would be to call the respective methods on Generator instance.

There's no good way of doing those using realText as it generates a text up to $maxNbChars. Also realText could return newlines, parts of a word, punctuations and what not.

So again: @fzaninotto Could you please elaborate a bit why "Lorem is never localised"?

[fzaninotto]

Lorem is for text that is in no language. For real language, use the Text provider.

If you need words and sentences with realtext, then we should add new methods (like realWord) to the Text provider, not localize Lorem.

[hertzg]

@fzaninotto Thanks for the explanation.

I've removed the lorem provider.

If you need words and sentences with realtext, then we should add new methods (like realWord) to the Text provider, not localize Lorem.

Yes. I definitely need a way to generate dummy localized words, sentences and paragraphs (similar to what Lorem provides, but localized).

So... How should we proceed?

[fzaninotto]

Thanks for this PR. For localized text, I suggest you work on the base Textprovider, and add realWord, realSentence, and realParagraphformatters - that should be enough to make them work in all languages. Then, if you're satisfied with the result, please open a new PR.