This repository has been archived by the owner on Mar 22, 2018. It is now read-only.
waitFor and waitTimeout : issue #39 #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…will be evaluated periodically within the phantomjs browser; if specified, screenshot-as-a-service won't take the screenshot until waitFor evaluates to true. Example: "function() {return Config.get('loaded') == true}" -- note, you must URI encode it. waitForTimeout specifies a maximum time to wait before giving up and rendering the screenshot anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the waitFor and waitTimeout parameters. waitFor will be evaluated periodically within the phantomjs browser; if specified, screenshot-as-a-service won't take the screenshot until waitFor evaluates to true. Example: "function() {return Config.get('loaded') == true}" -- note, you must URI encode it. waitForTimeout specifies a maximum time to wait before giving up and rendering the screenshot anyway.
I'm sure there's more I have to do, like update the readme. If you can take a look to see if it's functionally sound beforehand I'd appreciate it.