Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document what go.tools/importer commit pythia works with -- or vendor it #20

Closed
josharian opened this issue Jan 16, 2014 · 3 comments
Closed

Comments

@josharian
Copy link

My go.tools directory is at tip:

go.tools$ hg summary
parent: 657:a1ba4a15f741 tip
 go.tools/importer: API rethink.
go.tools$ hg tip
changeset:   657:a1ba4a15f741
tag:         tip
user:        Alan Donovan <adonovan@google.com>
date:        Wed Jan 15 21:37:55 2014 -0500
summary:     go.tools/importer: API rethink.

However, go get fails:

src$ go get github.com/fzipp/pythia
# github.com/fzipp/pythia
go/src/github.com/fzipp/pythia/main.go:34: undefined: importer.Importer
go/src/github.com/fzipp/pythia/main.go:74: undefined: importer.InitialPackagesUsage
go/src/github.com/fzipp/pythia/main.go:74: const initializer "Web frontend for the Go source code oracle.\nUsage: pythia [<flag> ...] <args> ...\n\nThe -http flag specifies the HTTP service address (e.g., ':6060').\n\nThe -tags flag specifies comma separated tags to use when importing\ncode (e.g., 'foo,!darwin').\n\nThe -open flag determines, whether the application should try to\nopen the browser. It is set to 'true' by default. If set to 'false'\nthe browser will not be launched.\n\nThe -v flag enables verbose mode, in which every incoming query\nto the oracle is logged to the standard output.\n\nExamples:\n\nStart pythia with the scope of package oracle:\n% pythia code.google.com/p/go.tools/cmd/oracle\n\nStart pythia with the scope of package image/png on port 8081,\nbut don't open the browser:\n% pythia -http=:8081 -open=false image/png\n" + importer.InitialPackagesUsage is not a constant
go/src/github.com/fzipp/pythia/main.go:100: undefined: importer.New
go/src/github.com/fzipp/pythia/main.go:101: cannot use args (type []string) as type io.Writer in function argument:
    []string does not implement io.Writer (missing Write method)
go/src/github.com/fzipp/pythia/main.go:101: cannot use nil as type bool in function argument
go/src/github.com/fzipp/pythia/main.go:101: too many arguments in call to oracle.New
go/src/github.com/fzipp/pythia/main.go:143: undefined: importer.Importer

I'd be happy to check out a different importer version, if it gets documented.

Better yet, you could vendor importer (via e.g. godep or goven), so that go get guaranteed to work...

Thanks!

@fzipp
Copy link
Owner

fzipp commented Jan 16, 2014

Thanks for the report, I've updated Pythia to the new API. I'm planning to vendor it soon.

fzipp added a commit that referenced this issue Jan 16, 2014
@fzipp
Copy link
Owner

fzipp commented Jan 16, 2014

The go.tools dependencies are vendored now.

@fzipp fzipp closed this as completed Jan 16, 2014
@josharian
Copy link
Author

Nice! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants