Migrate to NNBD #23
Merged
Migrate to NNBD #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the late review! I'll take a look ASAP, thanks for your effort 😄 |
|
Looking good! Thanks again! |
|
You're welcome! This was a great opportunity for me to get used to NNBD :) Mockito also put out a NNBD preview version since I've set up this PR, so you could pull it back in if you want. And flutter/flutter#72060 has been fixed, so the custom non-nullable color tween in the examples can be removed if you're okay with a high Flutter version constraint on the example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! This migrates the package to NNBD.
I migrated the examples too, but ran into flutter/flutter#72060.
I created a non-nullable version of ColorTween to work around it.