Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failure (though no real errors) #1727

Merged
merged 10 commits into from
Feb 7, 2024
Merged

Fix CI failure (though no real errors) #1727

merged 10 commits into from
Feb 7, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Feb 6, 2024

Changes

Close #1734

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy
Copy link
Owner Author

fzyzcjy commented Feb 6, 2024

Await: rustwasm/wasm-bindgen#3830

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10fded8) 99.11% compared to head (0de9f80) 99.11%.

❗ Current head 0de9f80 differs from pull request most recent head 56e4bda. Consider uploading reports for the commit 56e4bda to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1727   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         357      357           
  Lines       14751    14751           
=======================================
  Hits        14621    14621           
  Misses        130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy merged commit bcf070e into master Feb 7, 2024
99 of 100 checks passed
@fzyzcjy fzyzcjy deleted the feat/11838 branch February 7, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CI failure because upstream package fails to compile on nightly Rust
1 participant