rename scalar parameters in vec1, vec2, vec3, and vec4 (fixes C4458 in MSVC 2015) #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groovounet
added a commit
that referenced
this pull request
Sep 4, 2015
rename scalar parameters in vec1, vec2, vec3, and vec4 (fixes C4458 in MSVC 2015) #394
|
This looks great to me! Thanks for contributing, |
Groovounet
added a commit
that referenced
this pull request
Sep 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With msvc2015 the (new) warning C4458 occurs on all vector operators using scalars as parameters since they overlap with the union member s:
Example:
\glm-0.9.7.0\glm\detail\type_vec3.inl(302): warning C4458: declaration of 's' hides class memberFor projects that use highest warning levels for compilation (and some even with warnings as errors) this prohibits compilation.