Undefined reference errors #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename the parameters to match similar functions in other vector classes.
Groovounet
added a commit
that referenced
this pull request
Mar 12, 2016
Fixed undefined reference errors #489
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #488.
There were a few issues with different operator functions, which caused
undefined referenceerrors:glm/detail/type_vec4.inl; I also changed the parameter names to match similar functions in other vector classes)glm/detail/type_mat4x2.hpp).I guess you only get these errors if the template function is instantiated (i.e. you actually use the function). Weirdly enough, I don't get errors for all of the duplicate declarations I've fixed here (only some of them), but everything else produces an
undefined referenceerror without these changes.