Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a certification dialog box for printing. #46

Merged
merged 4 commits into from
Nov 18, 2021

Conversation

naoji3x
Copy link
Contributor

@naoji3x naoji3x commented Sep 25, 2021

I added react-to-print package to the project and added certification dialog box to src/views/User/User/User.js
I hope this pull request can contribute to the project.

@kaizumaki kaizumaki linked an issue Sep 26, 2021 that may be closed by this pull request
@chunyenHuang
Copy link
Member

chunyenHuang commented Nov 3, 2021

Thanks for the contribution. @naoji3x However, it does not show the logo in my loca
Screen Shot 2021-11-03 at 10 52 53 AM
l

@naoji3x
Copy link
Contributor Author

naoji3x commented Nov 4, 2021

@chunyenHuang
Thanks for your validation. That's very weird. I can see the logo in my local environment.
I guess I might have to change the path from "assets/images/pring-logo.png"
to "/assets/images/pring-logo.png". I will resend a pull request soon.
Screenshot 20211104

@chunyenHuang chunyenHuang merged commit a378ce7 into g0v:develop Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Printing friendly (UI)
2 participants