Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if listen ProjectsRegistry::setCurrentProject setter is still necessary #67

Open
volterra79 opened this issue Jul 15, 2022 · 2 comments
Open

Check if listen ProjectsRegistry::setCurrentProject setter is still necessary #67

volterra79 opened this issue Jul 15, 2022 · 2 comments
Labels
refactoring Anything which could result in a API change
Milestone
v3.10

Comments

@volterra79
Copy link
Member

volterra79 commented Jul 15, 2022 •
edited by Raruto

On version 3.4 is changed the way that change map (or change project) is handle. When changeProject is triggered, page is reloaded and no more ProjectsRegistry.onafter('setCurrentProject', project =>{ is useful
@Raruto Raruto changed the title check if listen 'setCurrentProject' setter is still necessary check if listen setCurrentProject setter is still necessary Jul 15, 2022
@Raruto Raruto added this to the 3.7 milestone Jul 29, 2022
@volterra79 volterra79 added the refactoring Anything which could result in a API change label Aug 5, 2022
@Raruto
Copy link
Collaborator

Raruto commented Sep 7, 2022

@volterra79 is there any specific line you are referring to?

@volterra79
Copy link
Member Author

@Raruto we need to find all of these type of line code and remove it. No more useful.

@Raruto Raruto modified the milestones: v3.7, v3.8 Jan 10, 2023
@Raruto Raruto changed the title check if listen setCurrentProject setter is still necessary Check if listen ProjectsRegistry::setCurrentProject setter is still necessary Jan 31, 2023
Raruto added a commit that referenced this issue Feb 7, 2023
@Raruto
Deprecate setters ProjectsRegistry~setCurrentProject(project) and `…
3460096 
…ProjectsRegistry~createProject(projectConfig)`

Start addressing: #67

As a result of: #150 we intend to bring the development environment ever closer to the production one.

Related to: #89, #292 and g3w-suite/g3w-suite-docker#79
@Raruto Raruto mentioned this issue Feb 7, 2023
Open
@Raruto Raruto modified the milestones: v3.8, v3.9 Aug 8, 2023
@Raruto Raruto modified the milestones: v3.9, v3.10 Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Anything which could result in a API change
Projects
None yet
Milestone
v3.10
Development

No branches or pull requests
2 participants
@volterra79 @Raruto