Share common docker-compose.yml configurations (PROD and DEV enviroments)
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove `docker-compose-consumer.yml` - add `G3WSUITE_RUN_HUEY` enviroment variable within `.env.example` (batch processing) - add `g3w-suite-consumer` within `docker-compose.yml` - refactor `docker-compose-consumer-dev.yml` in order to extend the base `docker-compose.yml` - remove `scripts/docker-entrypoint-dev.sh` - add support for `gunicorn.conf.py` within `scripts/docker-entrypoint.sh` (in order to share same server in various enviroments: PROD / DEV) - refactor `scripts/docker-consumer-entrypoint.sh` (ref. `G3WSUITE_RUN_HUEY`) - update `README.md` instructions related to batch processing usage - update `docker-compose.yml` version from `v3` to `v3.4`
Raruto
changed the title
docker-compose.yml configurations (PROD / DEV)docker-compose.yml configurations (PROD and DEV enviroments)
Raruto
commented
Sep 27, 2022
| workers = os.getenv('G3WSUITE_GUNICORN_NUM_WORKERS', 8) | ||
| max_requests = os.getenv('G3WSUITE_GUNICORN_MAX_REQUESTS', 200) | ||
| bind = '0.0.0.0:8000' | ||
| reload = False if os.getenv('G3WSUITE_DEBUG', 'False') == 'False' else True |
There was a problem hiding this comment.
Raruto
commented
Sep 27, 2022
| - FRONTEND | ||
| - G3WSUITE_GUNICORN_MAX_REQUESTS | ||
| - G3WSUITE_GUNICORN_NUM_WORKERS | ||
| - G3WSUITE_GUNICORN_TIMEOUT |
There was a problem hiding this comment.
Check if the huey service requires setting a different / greater value for the timeout (ref: G3WSUITE_GUNICORN_TIMEOUT).
Raruto
commented
Sep 27, 2022
| G3W-SUITE use `huey` for bach processing (https://github.com/coleifer/huey), so if you want to use it, | ||
| use `docker-compose-consumer.yml` file on deploy: | ||
| G3W-SUITE use `huey` for batch processing (https://github.com/coleifer/huey), so if you want to use it, | ||
| set `G3WSUITE_RUN_HUEY=True` enviroment variable and then deploy as usual: |
There was a problem hiding this comment.
rewrite this in a better English
…ose.yml` Related to: #75 (comment)
Raruto
commented
Nov 7, 2022
| @@ -1,19 +1,22 @@ | |||
| #!/bin/bash | |||
| # Entrypoint script fro deploy production | |||
| # Entrypoint script for deploy production | |||
| # --------------------------------------- | |||
|
|
|||
| # Start XVfb | |||
| if [[ -f /tmp/.X99-lock ]]; then | |||
| rm /tmp/.X99-lock | |||
| fi | |||
There was a problem hiding this comment.
Isn't the docker container stateless? (why we are trying to remove the /tmp/.X99-lock file from a previous run / reboot?)
See also: g3w-suite-docker/cmd.sh (commit history)
Raruto
commented
Nov 7, 2022
| - G3WSUITE_TILECACHE_PATH | ||
| - BITBUCKET_TOKEN | ||
| - G3WSUITE_DEBUG=${G3WSUITE_DEBUG:-True} | ||
| - G3WSUITE_GUNICORN_NUM_WORKERS=${G3WSUITE_GUNICORN_NUM_WORKERS:-1} | ||
| - G3WSUITE_QDJANGO_SERVER_URL |
There was a problem hiding this comment.
Check if the G3WSUITE_QDJANGO_SERVER_URL variable is still in use nowadays, currently it doesn't seem to have any production purpose (just forgotten to delete that also inside the docker-compose-dev.yml?)
1 task
Raruto
added a commit
to g3w-suite/g3w-client
that referenced
this pull request
Feb 7, 2023
…ProjectsRegistry~createProject(projectConfig)` Start addressing: #67 As a result of: #150 we intend to bring the development environment ever closer to the production one. Related to: #89, #292 and g3w-suite/g3w-suite-docker#79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes:
docker-compose-consumer.yml.env.example(G3WSUITE_RUN_HUEY) in order to enable batch processingdocker-compose.yml(g3w-suite-consumer)scripts/docker-entrypoint-dev.shdocker-compose-consumer-dev.ymlin order to extend the basedocker-compose.ymlscripts/docker-entrypoint.shin order to supportgunicorn.conf.pyconfiguration file (PROD and DEV server)scripts/docker-consumer-entrypoint.sh(ref.G3WSUITE_RUN_HUEY)README.mdinstructions related to batch processing usageREADME_DEV.mdinstructions related to development usagedocker-compose.ymlversion fromv3tov3.4docker-compose-dev.ymlversion fromv3tov3.4DISPLAYandQGIS_SERVER_PARALLEL_RENDERINGenvironment variables definitions fromscripts/docker-entrypoint.shtodocker-compose.ymlCloses: #66