fluka : lattice, merge, reflections and tests

[stewartboogert]

• reflection fixes in g4 to FLUKA conversion
• all FLUKA code to include tests of writing
• VTK visualisation bug fix ( M S R -> M R S) so should be S (reflection), R (rotation) and upstream transform M
• start merging FLUKA registries
• fix writing of transformations (RecursiveTransform, Transform etc.)
• File comparison tests for all FLUKA output

[codecov]

Codecov Report

Merging #83 (752ce06) into main (8d98320) will decrease coverage by 3.02%.
The diff coverage is 7.50%.

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   73.79%   70.78%   -3.02%     
==========================================
  Files         137      138       +1     
  Lines       20483    21530    +1047     
==========================================
+ Hits        15115    15239     +124     
- Misses       5368     6291     +923     

Files Changed	Coverage Δ
src/pyg4ometry/visualisation/ViewerBase.py	22.66% <0.00%> (ø)
src/pyg4ometry/convert/geant42FlukaBake.py	2.08% <2.08%> (ø)
src/pyg4ometry/fluka/fluka_registry.py	51.45% <20.00%> (-6.98%)	⬇️
src/pyg4ometry/fluka/material.py	77.05% <20.00%> (-3.57%)	⬇️
src/pyg4ometry/misc/TestUtils.py	57.57% <46.15%> (-42.43%)	⬇️
src/pyg4ometry/fluka/Writer.py	90.90% <85.18%> (-0.90%)	⬇️
src/pyg4ometry/convert/__init__.py	100.00% <100.00%> (ø)
src/pyg4ometry/convert/geant42Fluka.py	89.82% <100.00%> (ø)
src/pyg4ometry/fluka/body.py	89.83% <100.00%> (+5.20%)	⬆️
src/pyg4ometry/fluka/flair.py	92.85% <100.00%> (ø)
... and 1 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[lnevay]

Generally all good. I think though that creating a duplicate file (the bake one) for the conversion will have a bad outcome... Just now the two huge files are nearly identical, but only because one or two shapes are implement.

How about there's a function for each shape, then we make this a derived class and override only those bits. We have to have different behaviour if we bake in the transforms or not, therefore overriding a function would seem the way.

Or, could each fluka solid take the same input and the transform (when it's baked, the transform is set to None) and the solid constructor has a flag to bake in the transform?

As soon as we apply a fix for the conversion it will have to be done in two places just now.

[stewartboogert]

Completely agree. This PR was.supposed to be about lattice and other fluka functionality and turned into tests and some proof of principle ideas of how to fix the fluka conversion with reflections. So I have written up the change required in #92. I propose we merge this as it is blocking #91 and then fix the two code path problem later. Is this ok @lnevay