Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geant4 : (test) GDML test file comparison #91

Merged
merged 5 commits into from
Aug 27, 2023

Conversation

stewartboogert
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #91 (60927b0) into main (70079c5) will decrease coverage by 0.03%.
Report is 2 commits behind head on main.
The diff coverage is 70.96%.

❗ Current head 60927b0 differs from pull request most recent head 3b50650. Consider uploading reports for the commit 3b50650 to get more accurate results

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   70.65%   70.63%   -0.03%     
==========================================
  Files         139      138       -1     
  Lines       21567    21575       +8     
==========================================
+ Hits        15238    15239       +1     
- Misses       6329     6336       +7     
Files Changed Coverage Δ
src/pyg4ometry/cli.py 5.17% <0.00%> (ø)
src/pyg4ometry/geant4/LogicalVolume.py 63.33% <50.00%> (-3.27%) ⬇️
src/pyg4ometry/misc/TestUtils.py 45.83% <53.33%> (-11.75%) ⬇️
src/pyg4ometry/convert/geant42Geant4.py 51.51% <100.00%> (+31.51%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stewartboogert stewartboogert added the enhancement New feature or request label Aug 21, 2023
@stewartboogert stewartboogert marked this pull request as ready for review August 21, 2023 21:44
@stewartboogert stewartboogert merged commit 46ff170 into g4edge:main Aug 27, 2023
13 checks passed
@stewartboogert stewartboogert deleted the gdmlTestFileComparision branch August 27, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant