implement proper LDU2 encode/decode; implement proper HDU (Header) en… #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Thanks for improving P25. It was originally written very quickly, I am sure other parts need looking at too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…code/decode
I've completed an implemenation for the P25 protocol, to properly encode and decode the P25 HDU (Header) packet and the P25 LDU2 packet. This better completes the MMDVM implementation by properly generating data instead of relying on dummy constants. This also means that P25 encryption passes through an MMDVM correctly.
I've only lightly tested this, and would ask the community perform some heavier testing.