Skip to content
This repository has been archived by the owner on Jan 24, 2018. It is now read-only.

Fix client logging #324

Closed
dcolligan opened this issue Apr 1, 2015 · 2 comments
Closed

Fix client logging #324

dcolligan opened this issue Apr 1, 2015 · 2 comments
Labels

Comments

@dcolligan
Copy link
Member

Client logging has our messages entangled with urllib3's messages. We should probably suppress all of urllib3's messages.

Also, we don't really care about printing the debugLevel for our messages.

$ python client_dev.py -vv -O variants-search http://localhost:8000/v0.5.1
INFO:ga4gh.client:POST http://localhost:8000/v0.5.1/variantsets/search
DEBUG:ga4gh.client:json request:
DEBUG:ga4gh.client:{
    "datasetIds": [],
    "pageSize": null,
    "pageToken": null
}
INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): localhost
DEBUG:requests.packages.urllib3.connectionpool:"POST /v0.5.1/variantsets/search HTTP/1.1" 200 4887
DEBUG:ga4gh.client:json response:
DEBUG:ga4gh.client:{
    "nextPageToken": null,
    "variantSets": [
...
@jeromekelleher
Copy link
Contributor

I quite like urllib3's messages --- it's the only way I can see direct information about what's happening at the HTTP level. In particular, the response length is useful to know. I don't have an opinion either way when it comes to the debugLevel output.

@david4096
Copy link
Member

david4096 commented Nov 3, 2016

moved ga4gh/ga4gh-client#24

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants