Skip to content
This repository has been archived by the owner on Jan 24, 2018. It is now read-only.

404 status code returned incorrectly #883

Closed
david4096 opened this issue Jan 26, 2016 · 3 comments
Closed

404 status code returned incorrectly #883

david4096 opened this issue Jan 26, 2016 · 3 comments

Comments

@david4096
Copy link
Member

When using search endpoints a 404 status code is returned if the datasetId is not present. This breaks common conventions, 404 is meant when a resource does not exist. Common search idioms return empty lists when the search terms are not matched on.

@diekhans
Copy link
Contributor

@david4096 this should be a ticket in schemas, as they need to define
exactly what the expected behavior is.

David Steinberg notifications@github.com writes:

When using search endpoints a 404 status code is returned if the datasetId is
not present. This breaks common conventions, 404 is meant when a resource does
not exist. Common search idioms return empty lists when the search terms are
not matched on.


Reply to this email directly or view it on GitHub.*

@jeromekelleher
Copy link
Contributor

This is the documented behavior @david4096, and has been discussed a few times. This is a good example: ga4gh/ga4gh-schemas#382

I think Mark's SQL analogy is a good one.

Closing this issue as it is the documented behavior.

@david4096
Copy link
Member Author

Related ga4gh/ga4gh-schemas#382

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants