Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in new tesState for preempted state. #184

Merged
merged 5 commits into from
Sep 21, 2022
Merged

Add in new tesState for preempted state. #184

merged 5 commits into from
Sep 21, 2022

Conversation

vsmalladi
Copy link
Contributor

@vsmalladi vsmalladi commented Aug 8, 2022 •
edited
Loading

Close #183

Clouds/Job scheduler have preempted rules:

Solves : microsoft/CromwellOnAzure#451

MattMcL4475
MattMcL4475 suggested changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@MattMcL4475 MattMcL4475 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error for "PREEMPTED" . Also would recommend removing the white space changes which are unrelated and add noise

openapi/task_execution_service.openapi.yaml Outdated Show resolved Hide resolved
openapi/task_execution_service.openapi.yaml Outdated Show resolved Hide resolved
openapi/task_execution_service.openapi.yaml Outdated Show resolved Hide resolved
openapi/task_execution_service.openapi.yaml Outdated Show resolved Hide resolved
@vsmalladi vsmalladi changed the title Add in new tesState for preemted state. Add in new tesState for preempted state. Aug 8, 2022
@vsmalladi vsmalladi requested review from kellrott and MattMcL4475 and removed request for MattMcL4475 September 7, 2022 17:04
@vsmalladi vsmalladi added this to the 1.1 milestone Sep 7, 2022
@kellrott kellrott changed the base branch from develop to develop-1.1 September 21, 2022 05:22
@kellrott kellrott merged commit 5e42a7c into ga4gh:develop-1.1 Sep 21, 2022
@vsmalladi vsmalladi mentioned this pull request Sep 21, 2022
Closed
This was referenced Jan 23, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kellrott kellrott kellrott approved these changes

@MattMcL4475 MattMcL4475 MattMcL4475 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Proposal: New TES State for Preemption
3 participants
@vsmalladi @kellrott @MattMcL4475