Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CANCELING state to delete cloud resources #189

Merged
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions .github/workflows/lint-validate-openapi.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
name: Lint and validate OpenAPI specs

on:
- push
- pull_request

jobs:

lint:
name: Lint OpenAPI definition
runs-on: ubuntu-latest
steps:
- name: Check out head branch
uses: actions/checkout@v2
- name: Run OpenAPI Lint Action
uses: nwestfall/openapi-action@v1.0.2
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
file: openapi/task_execution_service.openapi.yaml

diff:
name: Show OpenAPI differences relative to target branch
runs-on: ubuntu-latest
if: ${{ github.event_name == 'pull_request' }}
steps:
- name: Check out head branch
uses: actions/checkout@v2
with:
ref: ${{ github.head_ref }}
path: head
- name: Check out base branch
uses: actions/checkout@v2
with:
ref: ${{ github.base_ref }}
path: base
- name: Run OpenAPI Diff Action
uses: mvegter/openapi-diff-action@v0.23.5
with:
head-spec: head/openapi/task_execution_service.openapi.yaml
base-spec: base/openapi/task_execution_service.openapi.yaml

validate:
name: Validate OpenAPI definition
runs-on: ubuntu-latest
steps:
- name: Check out head branch
uses: actions/checkout@v2
- name: Run OpenAPI Validate Action
uses: char0n/swagger-editor-validate@v1
with:
definition-file: openapi/task_execution_service.openapi.yaml
5 changes: 4 additions & 1 deletion openapi/task_execution_service.openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,9 @@ components:
- `SYSTEM_ERROR`: The task was stopped due to a system error, but not from an Executor,
for example an upload failed due to network issues, the worker's ran out
of disk space, etc.
- `CANCELED`: The task was canceled by the user.
- `CANCELED`: The task was canceled by the user, and downstream resources have been deleted.
- `CANCELLATION_REQUESTED`: The task was canceled by the user,
but the downstream resources are still awaiting deletion
default: UNKNOWN
example: COMPLETE
enum:
Expand All @@ -635,6 +637,7 @@ components:
- EXECUTOR_ERROR
- SYSTEM_ERROR
- CANCELED
- CANCELLATION_REQUESTED
tesTask:
required:
- executors
Expand Down