Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up and/or conversion issues from swagger 2.0 to openapi #229

Closed
denis-yuen opened this issue Dec 5, 2022 · 0 comments
Closed

Clean-up and/or conversion issues from swagger 2.0 to openapi #229

denis-yuen opened this issue Dec 5, 2022 · 0 comments
Milestone
v2.1

Comments

@denis-yuen
Copy link
Member

denis-yuen commented Dec 5, 2022 •
edited by unito-bot
Loading

  1. The swagger 2.0 is still kicking around the develop branch https://github.com/ga4gh/tool-registry-service-schemas/blob/develop/openapi/ga4gh-tool-discovery.yaml (on 2022-12-05). This looks like a bad merge conflict since it was supposed to be removed in e164249
  2. One endpoint has a plain/text response when it does not make sense https://github.com/ga4gh/tool-registry-service-schemas/blob/v2.0.1/openapi/openapi.yaml#L43-L45 . The plain text response was intended only for endpoints that return descriptors, this was likely a regression/conversion error since the swagger version does not have this issue

FYI @coverbeck

┆Issue is synchronized with this Jira Story
┆Project Name: Zzz-ARCHIVE GA4GH tool-registry-service
┆Issue Number: TRS-63
@denis-yuen denis-yuen added this to the v2.1 milestone Dec 5, 2022
@uniqueg uniqueg mentioned this issue Jan 4, 2023
Open
denis-yuen added a commit that referenced this issue Feb 16, 2023
@denis-yuen
swagger and v2 clean-up #229
e607bfa
@denis-yuen denis-yuen mentioned this issue Feb 16, 2023
Merged
denis-yuen added a commit that referenced this issue Apr 3, 2023
@denis-yuen
Feature/procedural cleanup (#238)
4204d76 
* update readme

* swagger and v2 clean-up #229

* script seems broken with feature branches

* Documentation updates for #114

* typo fix and trigger build

* fix link and really re-genrate TOC

* prep for next version and even more re-generate

* Incorporated current PR feedback

* Update README.md

* Update README.md
denis-yuen added a commit that referenced this issue Apr 5, 2023
@denis-yuen
Small comment round up (#239)
1dd4bf8 
* update readme

* swagger and v2 clean-up #229

* script seems broken with feature branches

* Documentation updates for #114

* typo fix and trigger build

* fix link and really re-genrate TOC

* prep for next version and even more re-generate

* propose tag-based search #205

* Add tool version specific description #228
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
1 participant
@denis-yuen