Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a write up on why we don't VOCA normalize "same as reference" alleles. #377

Closed
larrybabb opened this issue Feb 1, 2022 · 2 comments
Assignees
Labels

Comments

@larrybabb
Copy link
Contributor

@reece Would you have notes or be able to draft a paragraph or two on the policy decision we made regarding the rationale not to VOCA normalize "same as reference" variation? Our documentation could use this. Some folks have been asking.

Currently if someone tries to VRSify an allele that has a change from the reference we do a VOCA normalization to derive the fully normalized span of reference sequence and the dervied variation that would produce the change originally sought.

However, if someone tries to VRSify an allele that is the same as reference we do not do any VOCA normalization (but we do verify the sequence matches if provided...i assume) and simply use the exact span with the ref sequence as the state. If this span was within a repeated region it would NOT be expanded fully like a change from reference would.

Copy link

This issue was marked stale due to inactivity.

@github-actions github-actions bot added the Stale See .github/workflows/stale.yml label Jan 10, 2024
@ahwagner ahwagner removed the Stale See .github/workflows/stale.yml label Jan 10, 2024
@larrybabb
Copy link
Contributor Author

this was completed and merged in PR #381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants