Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default value for type attribute #389

Closed
korikuzma opened this issue Apr 13, 2022 · 1 comment · Fixed by #391 or #390
Closed

Add default value for type attribute #389

korikuzma opened this issue Apr 13, 2022 · 1 comment · Fixed by #391 or #390
Assignees
@korikuzma

Comments

@korikuzma
Copy link
Contributor

Without this, we must explicitly set the type when creating models in vrs-python in order to use methods like ga4gh_identify and any of the translator methods as seen in this issue.
@korikuzma korikuzma self-assigned this Apr 13, 2022
This was linked to pull requests Apr 15, 2022
1.2: Add default value for type in schemas, update smoketests readme #391
Merged
Add default value for types + update readme for using smoketests #390
Merged
@korikuzma
Copy link
Contributor Author

Did this in the main branch. Was waiting for #391 to close this issue, but looks like it's not needed. We can re-open if this is needed in older versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korikuzma korikuzma

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@korikuzma