Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default value for types + update readme for using smoketests #390

Merged
merged 1 commit into from Apr 14, 2022
Merged

Add default value for types + update readme for using smoketests #390

merged 1 commit into from Apr 14, 2022

Conversation

korikuzma
Copy link
Contributor

Ran tests in vrs-python (removed where we explicitly set type in the models) and everything passes

@korikuzma korikuzma marked this pull request as draft April 13, 2022 20:33
@korikuzma korikuzma marked this pull request as ready for review April 13, 2022 20:40
@ahwagner ahwagner merged commit ae5662e into main Apr 14, 2022
@korikuzma korikuzma linked an issue Apr 15, 2022 that may be closed by this pull request
Add default value for type attribute #389
Closed
@korikuzma korikuzma deleted the issue-389-add-default branch October 10, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahwagner ahwagner ahwagner approved these changes

@andreasprlic andreasprlic Awaiting requested review from andreasprlic andreasprlic is a code owner

@larrybabb larrybabb Awaiting requested review from larrybabb larrybabb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add default value for type attribute
2 participants
@korikuzma @ahwagner