Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

386: revise base64url description #387

Merged
merged 6 commits into from
Mar 28, 2022
Merged

386: revise base64url description #387

merged 6 commits into from
Mar 28, 2022

Conversation

ahwagner
Copy link
Member

No description provided.

@ahwagner
Copy link
Member Author

This closes #386. @jmarshall your review here is welcome.

@jmarshall
Copy link
Member

🤷 I think it's good that the introductory paragraph uses familiar terms, while steps 1–3 are more precise.

So I would just delete /URL/ leaving and [Base64](link) encoding. Or write out and the URL-friendly variant of [Base64](link) encoding if you wanted to avoid accusations of conceivably being misleading.

But it's all a bit bikesheddy, so whatever is good.

@jmarshall
Copy link
Member

Yeesh, how on earth did the readthedocs run for the first commit succeed? 😄 Has there been a massive readthedocs update in the last fourteen hours?

@ahwagner
Copy link
Member Author

I think Jinja2 is the culprit, made a breaking change in a minor version release an hour ago that Sphinx wasn't expecting: https://pypi.org/project/Jinja2/#history

@jmarshall
Copy link
Member

Yep. Looks like Sphinx 4.x would be insulated against the change BTW: sphinx-doc/sphinx@e5c905c.

@ahwagner ahwagner mentioned this pull request Mar 24, 2022
@ahwagner
Copy link
Member Author

@larrybabb and/or @andreasprlic you good with these changes?

Copy link
Contributor

@larrybabb larrybabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay.

@ahwagner ahwagner merged commit 8cde64e into main Mar 28, 2022
@ahwagner ahwagner deleted the issue-386 branch March 28, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants