Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relative_copy_class -> copy_assessment in CopyNumberChange example #419

Merged
merged 3 commits into from
Apr 2, 2023
Merged

relative_copy_class -> copy_assessment in CopyNumberChange example #419

merged 3 commits into from
Apr 2, 2023

Conversation

mbaudis
Copy link
Member

@mbaudis mbaudis commented Apr 1, 2023

IMO relative_copy_class should be copy_assessment in the CopyNumberChange example?

@mbaudis
relative_copy_class -> copy_assessment
7823558 
IMO `relative_copy_class`  should be `copy_assessment` in the `CopyNumberChange` example?
@ahwagner
Copy link
Member

ahwagner commented Apr 1, 2023

@mbaudis great catch, agreed this needs updating–and the attribute name as well (since this is no longer described as an "assessment" per #404).

How does this change look to you?

@ahwagner ahwagner merged commit f5f0feb into ga4gh:main Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasprlic andreasprlic Awaiting requested review from andreasprlic

@ahwagner ahwagner Awaiting requested review from ahwagner ahwagner is a code owner

@larrybabb larrybabb Awaiting requested review from larrybabb larrybabb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mbaudis @ahwagner