Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change IndefiniteRange.value to be an integer #498

Open
wants to merge 1 commit into
base: 1.3
Choose a base branch
from

Conversation

theferrit32
Copy link

@theferrit32 theferrit32 commented Jun 11, 2024

@larrybabb
Copy link
Contributor

@theferrit32 can you shed more light on why this was needed?

@theferrit32
Copy link
Author

theferrit32 commented Jun 12, 2024

Having this field (IndefiniteRange.value) be an integer to match the type of the Number.value field makes the graphQL query for those objects a little nicer because you can just ask for a field called value of type integer and it works for both IndefiniteRange and for Number

See item (1) here: broadinstitute/gnomad-browser#1472 (comment)

Here in the graphQL query if I want both IndefiniteRanges and Numbers to be returned in the same response I have to alias one of those value fields to have a different name, since the types don't match:
https://gist.github.com/theferrit32/df380899e9974cb885c2780cfa82ce7a#file-gnomad_vrs_va-graphql-L9

@larrybabb
Copy link
Contributor

@ahwagner I will defer to you on this one. If we merge this I think we may need a 1.4 release (unless you think it is acceptable to backport this into 1.3?). Please provide your perspective and proceed with whichever path you see as proper.

@dazzariti
Copy link

@larrybabb will review, remove Andreas as reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants