fix for ida 7.4 with python3.7 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'm pretty behind on Lighthouse maintenance right now :-X I haven't setup IDA with Python 3.x yet, so I haven't had a chance to test this. But there's at least a few tweaks I want to make before merging this. I also want to double check for compat & regressions. |
|
Found a few more minor issues, but now it LGTM. We'll see if anything else shakes out as people use it. For anyone else that finds/reads this PR, the dev branch of lighthouse should now be fully usable on IDA 7.4 with either py2 or py3. |
This was referenced Mar 29, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a dirty fix to be able to use lighthouse on ida pro 7.4 with python 3 (3.7)