Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async logger back thread should catch sink exceptions #1

Closed
gabime opened this issue Nov 3, 2014 · 1 comment
Closed

Async logger back thread should catch sink exceptions #1

gabime opened this issue Nov 3, 2014 · 1 comment
Assignees
@gabime
Labels
bug

Comments

@gabime
Copy link
Owner

gabime commented Nov 3, 2014

And possibly notify somehow to the calling thread about the exception
@gabime gabime added the bug label Nov 3, 2014
@gabime gabime self-assigned this Nov 3, 2014
@gabime
Copy link
Owner Author

gabime commented Nov 7, 2014

Fixed in commit 4bd25f8

@gabime gabime closed this as completed Nov 7, 2014
gabime pushed a commit that referenced this issue Dec 10, 2014
@rob-p
Merge pull request #1 from gabime/master
e166fad 
Synch with gambie
@dougtinkham dougtinkham mentioned this issue May 31, 2015
Closed
gabime pushed a commit that referenced this issue Jul 26, 2015
@a-martynovich
Merge pull request #1 from a-martynovich/master
e3518b6 
Add wchar_t support for Windows.
@JamesH65 JamesH65 mentioned this issue Feb 2, 2016
Closed
@sleger0507 sleger0507 mentioned this issue Feb 11, 2016
Closed
@dimagr-arm dimagr-arm mentioned this issue Jul 10, 2017
Closed
gabime pushed a commit that referenced this issue Oct 2, 2018
@blackball
Merge pull request #1 from blackball/blackball-patch-1
397c2a9 
Fix return type in README file.
@rayz55 rayz55 mentioned this issue Feb 7, 2019
Closed
@0x8000-0000 0x8000-0000 mentioned this issue Sep 3, 2019
Closed
@twisted89 twisted89 mentioned this issue Sep 20, 2019
Closed
@zh1an zh1an mentioned this issue Nov 28, 2019
Closed
@wangdiqi wangdiqi mentioned this issue Dec 10, 2019
Closed
@chengm349 chengm349 mentioned this issue Dec 27, 2019
Closed
This was referenced Apr 9, 2020
Closed
Closed
@SnowfallDan SnowfallDan mentioned this issue Jul 8, 2020
Closed
@streamsniper69 streamsniper69 mentioned this issue Feb 16, 2021
Closed
@m4infr4m3 m4infr4m3 mentioned this issue Mar 7, 2021
Closed
@gabime gabime mentioned this issue Feb 4, 2022
Closed
@deivse deivse mentioned this issue Feb 23, 2022
Closed
@wang332127858 wang332127858 mentioned this issue Sep 19, 2022
Closed
@gabime gabime mentioned this issue Dec 2, 2022
Closed
@zxz970104 zxz970104 mentioned this issue Jan 3, 2023
Closed
@LiXuefei007 LiXuefei007 mentioned this issue Mar 11, 2023
Closed
lucasrangit added a commit to lucasrangit/spdlog that referenced this issue Jul 5, 2023
@lucasrangit
sinks: android: handle when message is not loggable
4a233a8 
Android logger (since API 30) checks the per-tag property `log.tag.<tag>` to determine if a log message is loggable. See https://developer.android.com/ndk/reference/group/logging#__android_log_is_loggable . For example, `__android_log_buf_write` for a VERBOSE message will call `__android_log_is_loggable` and return `-EPERM` if the log message will not be printed because `log.tag.<tag>` is set to `INFO`.

Instead of erroring with the following error message, the Android sink should handle `-EPERM`. It is not an error to disable a log via the run-time property.

```
[*** LOG ERROR gabime#1 ***] [2023-06-29 00:50:26] [logcat] logging to Android failed: Unknown error -1 [/path/to/file.cpp(123)]
```
gabime pushed a commit that referenced this issue Jul 6, 2023
@lucasrangit
sinks: android: handle when message is not loggable (#2801)
01b3724 
Android logger (since API 30) checks the per-tag property `log.tag.<tag>` to determine if a log message is loggable. See https://developer.android.com/ndk/reference/group/logging#__android_log_is_loggable . For example, `__android_log_buf_write` for a VERBOSE message will call `__android_log_is_loggable` and return `-EPERM` if the log message will not be printed because `log.tag.<tag>` is set to `INFO`.

Instead of erroring with the following error message, the Android sink should handle `-EPERM`. It is not an error to disable a log via the run-time property.

```
[*** LOG ERROR #1 ***] [2023-06-29 00:50:26] [logcat] logging to Android failed: Unknown error -1 [/path/to/file.cpp(123)]
```
@develHector develHector mentioned this issue Nov 9, 2023
Closed
@luojc0517 luojc0517 mentioned this issue Dec 14, 2023
Closed
GerHobbelt pushed a commit to GerHobbelt/spdlog that referenced this issue Apr 7, 2024
@Craig-Proctor
Merge pull request gabime#1 from Esri/runtimecore-1.9.2
34be362 
arch: add build files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabime gabime

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gabime