Add Android sink #130
Add Android sink #130
Conversation
| case spdlog::level::critical: return ANDROID_LOG_FATAL; | ||
| case spdlog::level::alert: return ANDROID_LOG_FATAL; | ||
| case spdlog::level::emerg: return ANDROID_LOG_FATAL; | ||
| case spdlog::level::off: throw spdlog_ex("Unexpected off"); |
There was a problem hiding this comment.
Not sure about what is this level about, so just throw exception. Let me know if it's not correct.
There was a problem hiding this comment.
Off means no logging. It should not throw, just ignore the log
There was a problem hiding this comment.
Off means no logging. It should not throw, just ignore the log
Should we return from _sink_it (i.e. if (level == off) return) or check assert(level != off)?
| @@ -31,6 +31,7 @@ | |||
| #include "../sinks/file_sinks.h" | |||
| #include "../sinks/stdout_sinks.h" | |||
| #include "../sinks/syslog_sink.h" | |||
| #include "../sinks/android_sink.h" | |||
There was a problem hiding this comment.
No need to include this file. It is not used from splog_imple.h as far as i can tell
There was a problem hiding this comment.
I was thinking that the only file user need to include to work with library is #include "spdlog/spdlog.h" so I guess we need to include sinks/android_sink.h somewhere internally. I've just found other sinks and add android one there.
There was a problem hiding this comment.
No. They are included because they are used in this file. If android is not used in spdlog_impl.h, it should not included
There was a problem hiding this comment.
@gabime Okay, so to clarify: I'm removing this line and it means that if user want to use android sink he should include header manually, like #include <spdlog/sinks/android_sink.h. Guess it would be nice to document it somewhere (?)
|
@gabime updated |
No description provided.