Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require NdJSON to contain arrays and objects #219

Merged
merged 1 commit into from Dec 13, 2021
Merged

Conversation

gabriel-vasile
Copy link
Owner

@gabriel-vasile gabriel-vasile commented Dec 13, 2021

Previously, a files containing only JSON basic data types would be
reported as NdJSON. This change makeѕ NdJSON require to contain at least
one array or one object.

This is required so files containing

1
2
3

are not reported as ndjson. This is more inline with JSON detection, which also does not pass for single basic data types.

Previously, a files containing only JSON basic data types would be
reported as NdJSON. This change makeѕ NdJSON require to contain at least
one array or one object.
@gabriel-vasile gabriel-vasile merged commit 12e1ead into master Dec 13, 2021
@gabriel-vasile gabriel-vasile deleted the ndjson branch December 13, 2021 14:57
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.429% when pulling 2e75863 on ndjson into 9908b3e on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants