Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for NDJSON file format #41

Merged
merged 1 commit into from Sep 2, 2019
Merged

Add support for NDJSON file format #41

merged 1 commit into from Sep 2, 2019

Conversation

divyanshgaba
Copy link

Closes #40

@divyanshgaba divyanshgaba mentioned this pull request Sep 2, 2019
Closed
@coveralls
Copy link

coveralls commented Sep 2, 2019 •
edited

Pull Request Test Coverage Report for Build 145

  • 29 of 34 (85.29%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 93.891%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/matchers/text.go 29 34 85.29%
Totals Coverage Status
Change from base Build 144: 0.3%
Covered Lines: 999
Relevant Lines: 1064
💛 - Coveralls

@gabriel-vasile gabriel-vasile merged commit c9b95c7 into gabriel-vasile:master Sep 2, 2019
@gabriel-vasile
Copy link
Owner

Code looks good! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for NDJSON file format
4 participants
@divyanshgaba @coveralls @gabriel-vasile @macrena