Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndg fix #289

Merged
merged 1 commit into from
Mar 9, 2020
Merged

ndg fix #289

merged 1 commit into from
Mar 9, 2020

Conversation

jrpope2014
Copy link
Contributor

made changes to versioning info as well as added an import with conditional usage of inject_into/extract_from urllib3 to allow ndg-httpsclient==0.4.0 to be present at the same time as httpretty

…nd for ndg to be present at the same time as httpretty
@jrpope2014
Copy link
Contributor Author

Note: The code I used here was implemented by @jmcbailey (to appropriate credit correctly) in reference to the following issue:

#242

@gabrielfalcao
Copy link
Owner

hey thanks for this, I would love to get this PR merged, but it does not have any automated tests.
Please keep in mind that HTTPretty is trusted by many individuals and organizations and we need to ensure that any changes (whether bugfix or feature) must not break existing behavior.

  • If your PR is a bugfix, please add automated test(s) to prove that the bug is reproducible
  • If your PR is a feature, please add automated test(s) to ensure that your feature works as expected

PR's without tests will NOT be merged, as I don't have time to debug your code, and write tests in your behalf.

Thank you so much for your time

@iurisilvio iurisilvio mentioned this pull request Jun 20, 2016
@iurisilvio
Copy link

Current tests break if you have ndg-httpsclient>=0.4 installed. I sent a PR with a tox env to reproduce the issue.

@andrewgross
Copy link
Collaborator

Added a PR with tests that fixes the issue, and fixed the master branch. I'll ping gabe and have him do a release when he has a chance.

jonnybazookatone pushed a commit to jonnybazookatone/ads that referenced this pull request May 27, 2017
There is still an ongoing ticket on HTTPretty, that is yet to be addressed
and closed:

gabrielfalcao/HTTPretty#242
gabrielfalcao/HTTPretty#289

For now, used the suggested fix from @jmcbailey in the same thread.
@gabrielfalcao gabrielfalcao merged commit c116d7d into gabrielfalcao:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants