Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch out urllib monkeypatching when installed, adds tests for behavior #308

Closed
wants to merge 2 commits into from
Closed

Patch out urllib monkeypatching when installed, adds tests for behavior #308

wants to merge 2 commits into from

Conversation

andrewgross
Copy link
Collaborator

This duplicates #289 but adds tests as well (had issues cloning original PR).
Addresses ticket #242.

Does not bump version.

@andrewgross
Copy link
Collaborator Author

I spent a lot of time trying to get the function call mocked with mock and patch but to no avail. I lost patience and just ran it manually in the test.

@gabrielfalcao
Copy link
Owner

@andrewgross 🙏 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrewgross @gabrielfalcao