allow https requests to properly pass through HTTPretty #290
Conversation
|
I'm so sad that this PR broke the continuous integration, such a great contribution! |
…y hangs on python 2.7.10
|
i'm still not seeing this work correctly with the latests requests + requests[security].. i never get to readall, because the urllib3 connectionpool verifies the connection before sending. i've narrowed it down to not doing a connect on truesock here, even if the request does not match any registered httpretty entries. unfortunately at this level, we only have the host and port, which is not enough information to be able to match. which leads me to believe that we may have to monkey patch supported libraries to add information for the socket to use if necessary. does this seem like a reasonable approach? |
| @@ -98,6 +98,7 @@ | |||
| if not PY3: | |||
| old_sslwrap_simple = ssl.sslwrap_simple | |||
| old_sslsocket = ssl.SSLSocket | |||
| old_sslcontext = ssl.SSLContext(ssl.PROTOCOL_SSLv23) | |||
There was a problem hiding this comment.
where is this variable being used?
I think this will also need to set truesock back to the original socket at some point.