Fixed deprecated usage of isAlive() #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
==========================================
- Coverage 94.91% 94.56% -0.36%
==========================================
Files 7 7
Lines 846 846
==========================================
- Hits 803 800 -3
- Misses 43 46 +3
Continue to review full report at Codecov.
|
|
@gabrielfalcao could we get this merged? |
damdo
added a commit
to pusher/pusher-http-python
that referenced
this pull request
Jul 26, 2019
httpretty throws: - a PendingDeprecationWarning : httpretty/core.py:438: PendingDeprecationWarning: isAlive() is deprecated, use is_alive() instead if t.isAlive(): - a ResourceWarning : httpretty/core.py:485: ResourceWarning: unclosed file <_io.BufferedRandom name=7> self.fd = FakeSockFile() There already are issues and PRs to fix these: - gabrielfalcao/HTTPretty#368 - gabrielfalcao/HTTPretty#377 Until they are fixed I'm suppressing them
|
@gabrielfalcao any updates on when we can have this patch? |
|
@kamikaz1k thanks for the reminder <3 |
|
fixed and released on 0.9.7 |
damdo
added a commit
to pusher/pusher-http-python
that referenced
this pull request
Oct 25, 2019
it bumps the httpretty version to 0.9.7, which fixes the warning on isAlive. ref: gabrielfalcao/HTTPretty#377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isAlive() is deprecated, use is_alive() instead