-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mock as dependency #161
Conversation
Speaking as the new volunteer maintainer of the |
Hi @gabrielfalcao, Arch Linux is also moving away from mock https://archlinux.org/todo/drop-python-mock-checkdepends/. I cannot test this patch due to conflicts. Could you rebase it? Thanks! Update: https://github.com/gabrielfalcao/sure/blob/master/tests/test_assertion_builder.py also uses mock. It will be great if unittest.mock is also used there. |
* Move away from python-mock [1] with a patch based on upstream one [2] * Move away from `python setup.py test` [3] as well as switching from nosetests to pytest, which is supported since 2.0.0 [4]. This allows dropping python-rednose from checkdepends but python-nose is still needed [5] * Mention myself as a maintainer [1] https://archlinux.org/todo/drop-python-mock-checkdepends/ [2] gabrielfalcao/sure#161 [3] https://archlinux.org/todo/stop-using-python-setuppy-test/ [4] gabrielfalcao/sure#175 [5] gabrielfalcao/sure#182 git-svn-id: file:///srv/repos/svn-community/svn@1349110 9fca08f4-af9d-4005-b8df-a31f2cc04f65
* Move away from python-mock [1] with a patch based on upstream one [2] * Move away from `python setup.py test` [3] as well as switching from nosetests to pytest, which is supported since 2.0.0 [4]. This allows dropping python-rednose from checkdepends but python-nose is still needed [5] * Mention myself as a maintainer [1] https://archlinux.org/todo/drop-python-mock-checkdepends/ [2] gabrielfalcao/sure#161 [3] https://archlinux.org/todo/stop-using-python-setuppy-test/ [4] gabrielfalcao/sure#175 [5] gabrielfalcao/sure#182 git-svn-id: file:///srv/repos/svn-community/svn@1349110 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Pull Request Type
Summary
This is a fix for #146 following the suggestion by @adammartin-mednax to remove mock as dependency.
Additionally all tests now run with nose and pytest.