Skip to content
This repository has been archived by the owner on Jul 23, 2022. It is now read-only.

@Override annotation is duplicated #26

Closed
Maragues opened this issue May 30, 2016 · 2 comments · Fixed by #27
Closed

@Override annotation is duplicated #26

Maragues opened this issue May 30, 2016 · 2 comments · Fixed by #27

Comments

@Maragues
Copy link

Maragues commented May 30, 2016

Due to #24, I was forced to add a non-generics implementation such as the following

  @NonNull
  @Override
  public abstract Timeline withUploadStatus(@NonNull UPLOAD_STATUS status);

auto-value-with generates the withUploadStatus method with a duplicated @OverRide annotation, which of course throws a duplicate annotation compile time error

  @Override
  @NonNull
  @Override
  public final Timeline withUploadStatus(ISynchronizable.UPLOAD_STATUS uploadStatus) {
    return new AutoValue_Timeline(id(), ..., uploadStatus, ...);
  }

Removing the @OverRide annotation fixes the issue.

@gabrielittner
Copy link
Owner

I think it will work when you remove @OverRide from your overridden method.
I'm on mobile right now but will take a look later today

On Mon, 30 May 2016, 11:45 Miguel Aragues, notifications@github.com wrote:

Due to #24 #24,
I was forced to add a non-generics implementation such as the following

@nonnull
@OverRide
public abstract Timeline withUploadStatus(@nonnull UPLOAD_STATUS status);

auto-value-with generates the withUploadStatus method with a duplicated
@OverRide https://github.com/Override annotation, which of course
throws a duplicate annotation compile time error

@OverRide
@nonnull
@OverRide
public final Timeline withUploadStatus(ISynchronizable.UPLOAD_STATUS uploadStatus) {
return new AutoValue_Timeline(id(), ..., uploadStatus, ...);
}


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#26, or mute the
thread
https://github.com/notifications/unsubscribe/ABS5GYMbJWR9TgRYiXAhjJR_RVXk5MAyks5qGrHIgaJpZM4IpphS
.

@Maragues
Copy link
Author

Yes, that fixes the issue, I just wanted to let you know.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants