Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test faster svd / pca variants #3

Open
gabrielodom opened this issue Jun 1, 2018 · 2 comments
Open

Test faster svd / pca variants #3

gabrielodom opened this issue Jun 1, 2018 · 2 comments
Assignees

Comments

@gabrielodom
Copy link
Owner

The package currently uses the "mysvd()" function to extract vanilla PCs for the supervised PCA approach. Test alternative pca / svd algorithms (and even an if {} else {} setup for the cases when the pathway dimension is greater than the sample size).

@gabrielodom gabrielodom added this to the Bioconductor Submission milestone Jun 1, 2018
@gabrielodom gabrielodom self-assigned this Jun 1, 2018
@gabrielodom
Copy link
Owner Author

I've tested a few svd / pca variants. I think I'll use the RSpectra package. The svds and eigs functions are almost twice as fast as the corpcor::fast.svd function (which is incidentally slightly slower than base::svd). The only rub is that this technique (I think) precludes the possibility of specifying the percent of variation to preserve.

@gabrielodom
Copy link
Owner Author

After speaking with Prof. Chen, we will take a hard look at the time difference between using base::svd and RSpectra::svds for a real pathway set. This is because coprcor::fast.svd is marginally--but not significantly--slower than the base SVD function. If the time difference between RSpectra and base is practically significant, then we will use the SVD function from this package; otherwise, we'll cut out another package call and use base instead (this is my preference).

@gabrielodom gabrielodom changed the title Test more efficient svd / pca variants Test faster svd / pca variants Aug 20, 2018
@gabrielodom gabrielodom removed this from the Bioconductor Submission milestone Aug 20, 2018
gabrielodom added a commit that referenced this issue Aug 30, 2018
…than base svd for pathway matrices. We may still want a "faster" SVD option for Supervised PCA in the future, but I've removed this unnecessary dependency for now.
gabrielodom added a commit that referenced this issue Oct 1, 2018
…e internal keyword to some functions. Concerning Issue #3, the mysvd() function can now take any decomposition as an input, but it defaults to base::svd
gabrielodom added a commit that referenced this issue Feb 14, 2019
…than base svd for pathway matrices. We may still want a "faster" SVD option for Supervised PCA in the future, but I've removed this unnecessary dependency for now.
gabrielodom added a commit that referenced this issue Feb 14, 2019
…e internal keyword to some functions. Concerning Issue #3, the mysvd() function can now take any decomposition as an input, but it defaults to base::svd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant